[
https://issues.apache.org/jira/browse/YARN-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13830338#comment-13830338
]
Zhijie Shen commented on YARN-967:
----------------------------------
1. Should be "doesn't exist in RM and AHS"
{code}
/**
* This exception is thrown on
* {@link
ApplicationClientProtocol#getApplicationReport(GetApplicationReportRequest)} API
* when the Application doesn't exist in RM
*/
public class ApplicationNotFoundException extends YarnException{
{code}
2. Wrong javadoc. Same for ContainerNotFoundException
{code}
+ * when the Application doesn't exist in Application History Server
+ */
+public class ApplicationAttemptNotFoundException extends YarnException{
{code}
3. Remove the application.
{code}
/**
+ * Prints the container report for an application container id.
{code}
4. Is it good to list the variable-length fields "Tracking-URL" and "LOG-URL".
Before, listApplications list Tracking-URL which is much predictable, because
it points to the AM for running applications. Now, for the finished
applications, they may be updated and the length is predictable. I'm not sure
it will fit into the line format. [~vinodkv], do you have any idea?
{code}
+ writer.printf(APPLICATION_ATTEMPTS_PATTERN, "ApplicationAttempt-Id",
+ "State", "AM-Container-Id", "Tracking-URL");
{code}
{code}
+ writer.printf(CONTAINER_PATTERN, "Container-Id", "Start Time",
+ "Finish Time", "State", "Host", "LOG-URL");
{code}
5. Unnecessary change on TestYarnClient.
6. Seems not to be necessary to extend RMProxy, even not necessary to create
AHSProxy. How about invoking:
{code}
YarnRPC.create(conf).getProxy(...)
{code}
directly where you call AHSProxy.
7. TestYarnCLI should test getAttempts and Containers (plural) as well, right?
BTW, have you tested locally that the CLI works?
> [YARN-321] Command Line Interface(CLI) for Reading Application History
> Storage Data
> -----------------------------------------------------------------------------------
>
> Key: YARN-967
> URL: https://issues.apache.org/jira/browse/YARN-967
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Devaraj K
> Assignee: Mayank Bansal
> Attachments: YARN-967-1.patch, YARN-967-2.patch, YARN-967-3.patch,
> YARN-967-4.patch, YARN-967-5.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1#6144)
