[
https://issues.apache.org/jira/browse/YARN-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13832119#comment-13832119
]
Mayank Bansal commented on YARN-967:
------------------------------------
Thanks [~vinodkv] and [~zjshen] for review
bq. 1. Should be "doesn't exist in RM and AHS"
Done
bq.2. Wrong javadoc. Same for ContainerNotFoundException
Done
bq.3. Remove the application.
Done
bq.4. Is it good to list the variable-length fields "Tracking-URL" and
"LOG-URL". Before, listApplications list Tracking-URL which is much
predictable, because it points to the AM for running applications. Now, for the
finished applications, they may be updated and the length is predictable. I'm
not sure it will fit into the line format. Vinod Kumar Vavilapalli, do you have
any idea?
I think we should have it , I t ested it and working fine.
bq. 5. Unnecessary change on TestYarnClient.
Those are unnecessary imports, we should remove those.
bq. 6. Seems not to be necessary to extend RMProxy, even not necessary to
create AHSProxy. How about invoking:
Done
bq. 7. TestYarnCLI should test getAttempts and Containers (plural) as well,
right?
Done
bq. BTW, have you tested locally that the CLI works?
Yes its working fine.
bq. if a user uses YarnClient, he/she shouldn't even know about AHSClient? In a
way, YarnClient should explicitly compose AHSClient and redirect APIs
accordingly. In that case, CLI etc shouldn't even have any changes?
Removed from CLI and added into client.
Thanks,
Mayank
> [YARN-321] Command Line Interface(CLI) for Reading Application History
> Storage Data
> -----------------------------------------------------------------------------------
>
> Key: YARN-967
> URL: https://issues.apache.org/jira/browse/YARN-967
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Devaraj K
> Assignee: Mayank Bansal
> Attachments: YARN-967-1.patch, YARN-967-2.patch, YARN-967-3.patch,
> YARN-967-4.patch, YARN-967-5.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1#6144)
