[
https://issues.apache.org/jira/browse/YARN-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13832385#comment-13832385
]
Zhijie Shen commented on YARN-967:
----------------------------------
1. It's better to put it in serviceStart() instead of serviceInit()
{code}
+ historyClient.start();
{code}
2. Undo the unnecessary change in YarnCLI.
3. Undo the unnecessary change in RMProxy
4. You may want to move the tests in TestYarnCLI to TestYarnClient, or you want
to test both. Now YarnClient has been changed as well, however, TestYarnCLI
mocks YarnClient and assume the methods work fine.
> [YARN-321] Command Line Interface(CLI) for Reading Application History
> Storage Data
> -----------------------------------------------------------------------------------
>
> Key: YARN-967
> URL: https://issues.apache.org/jira/browse/YARN-967
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Devaraj K
> Assignee: Mayank Bansal
> Attachments: YARN-967-1.patch, YARN-967-2.patch, YARN-967-3.patch,
> YARN-967-4.patch, YARN-967-5.patch, YARN-967-6.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1#6144)
