[ 
https://issues.apache.org/jira/browse/YARN-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14299306#comment-14299306
 ] 

Hadoop QA commented on YARN-3101:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12695624/YARN-3101-Siqi.v2.patch
  against trunk revision 951b360.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

    {color:red}-1 javac{color:red}.  The patch appears to cause the build to 
fail.

Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6470//console

This message is automatically generated.

> FairScheduler#fitInMaxShare was added to validate reservations but it does 
> not consider it 
> -------------------------------------------------------------------------------------------
>
>                 Key: YARN-3101
>                 URL: https://issues.apache.org/jira/browse/YARN-3101
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: fairscheduler
>            Reporter: Anubhav Dhoot
>            Assignee: Anubhav Dhoot
>         Attachments: YARN-3101-Siqi.v1.patch, YARN-3101-Siqi.v2.patch, 
> YARN-3101.001.patch, YARN-3101.002.patch
>
>
> YARN-2811 added fitInMaxShare to validate reservations on a queue, but did 
> not count it during its calculations. It also had the condition reversed so 
> the test was still passing because both cancelled each other. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to