[
https://issues.apache.org/jira/browse/YARN-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14299348#comment-14299348
]
Anubhav Dhoot commented on YARN-3101:
-------------------------------------
Hi [~l201514] why do we need to make the comparator < instead <=. What case
does this address?
[~sandyr] I did not see a check when placing a reservation. We check a queue
usage once in FSLeafQueue#assignContainerPreCheck but we do not know the
container size until actual reserve happens in FSAppAttempt reserve.
> FairScheduler#fitInMaxShare was added to validate reservations but it does
> not consider it
> -------------------------------------------------------------------------------------------
>
> Key: YARN-3101
> URL: https://issues.apache.org/jira/browse/YARN-3101
> Project: Hadoop YARN
> Issue Type: Bug
> Components: fairscheduler
> Reporter: Anubhav Dhoot
> Assignee: Anubhav Dhoot
> Attachments: YARN-3101-Siqi.v1.patch, YARN-3101-Siqi.v2.patch,
> YARN-3101.001.patch, YARN-3101.002.patch
>
>
> YARN-2811 added fitInMaxShare to validate reservations on a queue, but did
> not count it during its calculations. It also had the condition reversed so
> the test was still passing because both cancelled each other.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
