Tsuyoshi Ozawa commented on YARN-2890:

[~mitdesai] thank you for updating a patch! +1 for the change itself to make it 

I was trying out the fix for MiniMRYarnCluster where we want to start the 
timeline service only if the TIMELINE_SERVICE_ENABLED == true. But as per 
current implementation of the miniCluster, it takes in a boolean when its 
instance is created to decide whether to start or not to start the timeline 

I don't understand the context - why you'd like to make the flag off by 
default? Could you clarify it? IMO, it would be enough to make it configurable. 

> MiniMRYarnCluster should turn on timeline service if configured to do so
> ------------------------------------------------------------------------
>                 Key: YARN-2890
>                 URL: https://issues.apache.org/jira/browse/YARN-2890
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Mit Desai
>            Assignee: Mit Desai
>         Attachments: YARN-2890.patch, YARN-2890.patch, YARN-2890.patch, 
> YARN-2890.patch, YARN-2890.patch
> Currently the MiniMRYarnCluster does not consider the configuration value for 
> enabling timeline service before starting. The MiniYarnCluster should only 
> start the timeline service if it is configured to do so.

This message was sent by Atlassian JIRA

Reply via email to