[ 
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361084#comment-14361084
 ] 

Hitesh Shah commented on YARN-2890:
-----------------------------------

Thanks [~mitdesai]. In the future, it would be good if your patches are 
versioned to avoid confusion. 

More questions on the patch:

  - testTimelineServiceStartInMiniCluster() - is there a reason why a job is 
run when timeline is enabled but not run when it is disabled? 
    - should be a job run be needed here in the first place given the name of 
the test?
    - might be better to move the testing of job runs based on absence/presence 
of timeline to a separate test

 - testMRTimelineEventHandling, testMapreduceJobTimelineServiceEnabled, 
testMapreduceJobTimelineServiceEnabled
   - is there a need to change all of them?
   - there does not seem to be a code path that tests timeline being enabled by 
passing the enableAHS value in the ctor if all these are changed.


  

> MiniMRYarnCluster should turn on timeline service if configured to do so
> ------------------------------------------------------------------------
>
>                 Key: YARN-2890
>                 URL: https://issues.apache.org/jira/browse/YARN-2890
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Mit Desai
>            Assignee: Mit Desai
>         Attachments: YARN-2890.patch, YARN-2890.patch, YARN-2890.patch, 
> YARN-2890.patch, YARN-2890.patch
>
>
> Currently the MiniMRYarnCluster does not consider the configuration value for 
> enabling timeline service before starting. The MiniYarnCluster should only 
> start the timeline service if it is configured to do so.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to