[ 
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360809#comment-14360809
 ] 

Hitesh Shah commented on YARN-2890:
-----------------------------------

2 issues with the patch: 

{code}
public MiniMRYarnCluster(String testName, int noOfNMs, boolean enableAHS)
{code}

The above ctor was removed. If anyone is using MiniMRYARNCluster from 2.4.0 to 
test their jobs, this will break compatibility.

{code}
conf.getBoolean(YarnConfiguration.TIMELINE_SERVICE_ENABLED, false)
{code}

Why use a hardcoded false instead of the DEFAULT field from YarnConfiguration?

Also, to add to Tsuyoshi's comment, what is the issue with turning on Timeline 
in all scenarios? If Timeline is going to be a first class citizen of YARN 
going forwards, why make it false by default? [~zjshen] comments on this?



> MiniMRYarnCluster should turn on timeline service if configured to do so
> ------------------------------------------------------------------------
>
>                 Key: YARN-2890
>                 URL: https://issues.apache.org/jira/browse/YARN-2890
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Mit Desai
>            Assignee: Mit Desai
>         Attachments: YARN-2890.patch, YARN-2890.patch, YARN-2890.patch, 
> YARN-2890.patch, YARN-2890.patch
>
>
> Currently the MiniMRYarnCluster does not consider the configuration value for 
> enabling timeline service before starting. The MiniYarnCluster should only 
> start the timeline service if it is configured to do so.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to