[
https://issues.apache.org/jira/browse/YARN-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14380907#comment-14380907
]
Hitesh Shah commented on YARN-2890:
-----------------------------------
Most of the comments sound fine. As long as there is a new test added to test
the AHS enable/disable codepath via the ctor flag, leaving the original tests
to use the config should be fine ( with a minor addition stated below ).
Just a note though, at some point, the config flag will be changed from default
false to true as ATS becomes stable so there does need to be tests covering all
4 cases ( true/false via config and likewise via ctor ).
> MiniMRYarnCluster should turn on timeline service if configured to do so
> ------------------------------------------------------------------------
>
> Key: YARN-2890
> URL: https://issues.apache.org/jira/browse/YARN-2890
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 2.6.0
> Reporter: Mit Desai
> Assignee: Mit Desai
> Attachments: YARN-2890.patch, YARN-2890.patch, YARN-2890.patch,
> YARN-2890.patch, YARN-2890.patch
>
>
> Currently the MiniMRYarnCluster does not consider the configuration value for
> enabling timeline service before starting. The MiniYarnCluster should only
> start the timeline service if it is configured to do so.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
