Sangjin Lee commented on YARN-3390:

Thanks [~Naganarasimha] and [~zjshen]! I'll take a look at the patch a little 
more closely later. I just wanted to bring to your attention YARN-3437. There I 
did a fairly similar (but not identical) refactoring of 
TimelineCollectorManager as part of isolating the core piece of the timeline 
collector manager independent of the NM-TS interaction, etc. So hopefully we 
can arrive at a version that can satisfy both needs.

Also, a small nit: I'm not too sure if I like the name 
"NMTimelineCollectorManager" (the "NM" part of it). It suggests bit too 
strongly that this is part of the NM. How about "NodeTimelineCollectorManager" 
or another bit more independent name? I can't think of many other alternatives, 
so any suggestion is welcome.

> Reuse TimelineCollectorManager for RM
> -------------------------------------
>                 Key: YARN-3390
>                 URL: https://issues.apache.org/jira/browse/YARN-3390
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
>         Attachments: YARN-3390.1.patch
> RMTimelineCollector should have the context info of each app whose entity  
> has been put

This message was sent by Atlassian JIRA

Reply via email to