[
https://issues.apache.org/jira/browse/YARN-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14497341#comment-14497341
]
Sangjin Lee commented on YARN-3390:
-----------------------------------
I took a pass at the patch, and it looks good for the most part. I would ask
you to reconcile the TimelineCollectorManager changes with what I have over on
YARN-3437. Again, I have a slight preference for the hook/template methods for
the aforementioned reason, but it's not a strong preference one way or another.
However, I'm not sure why there is a change for RMContainerAllocator.java. It
doesn't look like an intended change?
> Reuse TimelineCollectorManager for RM
> -------------------------------------
>
> Key: YARN-3390
> URL: https://issues.apache.org/jira/browse/YARN-3390
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Zhijie Shen
> Assignee: Zhijie Shen
> Attachments: YARN-3390.1.patch
>
>
> RMTimelineCollector should have the context info of each app whose entity
> has been put
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
