Naganarasimha G R commented on YARN-2740:

bq. No, we've decided to support remove node labels while distributed config 
enabled, I think it's better to add test to make sure it works in distributed 
mode. Since "remove label = remove label in the cluster + remove label in 
nodes, it's a defensive test case to avoid future code changes break this.
ok got it, had misread your comment earlier
bq. We can continue to support both of the 2, just extra common part should be 
ok, Will extract the common part to a method .

> ResourceManager side should properly handle node label modifications when 
> distributed node label configuration enabled
> ----------------------------------------------------------------------------------------------------------------------
>                 Key: YARN-2740
>                 URL: https://issues.apache.org/jira/browse/YARN-2740
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Naganarasimha G R
>             Fix For: 2.8.0
>         Attachments: YARN-2740-20141024-1.patch, YARN-2740.20150320-1.patch, 
> YARN-2740.20150327-1.patch, YARN-2740.20150411-1.patch, 
> YARN-2740.20150411-2.patch, YARN-2740.20150411-3.patch, 
> YARN-2740.20150417-1.patch, YARN-2740.20150420-1.patch, 
> YARN-2740.20150421-1.patch
> According to YARN-2495, when distributed node label configuration is enabled:
> - RMAdmin / REST API should reject change labels on node operations.
> - CommonNodeLabelsManager shouldn't persist labels on nodes when NM do 
> heartbeat.

This message was sent by Atlassian JIRA

Reply via email to