[ 
https://issues.apache.org/jira/browse/YARN-2740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14505709#comment-14505709
 ] 

Wangda Tan commented on YARN-2740:
----------------------------------

General LGTM, some minor comments.

1) Mark YarnConfiguration.isDistributedNodeLabelConfiguration to @Private
2) It's better to cover remove label case since remove label = remove label in 
the cluster + remove label in nodes, add a test to make sure it works in 
distributed mode, same as TestRMAdminService/TestRMWebServicesNodeLabels
3) RMWebServices.replaceLabelsOnNode(s) should be merged to avoid we need to 
maintain both.

> ResourceManager side should properly handle node label modifications when 
> distributed node label configuration enabled
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-2740
>                 URL: https://issues.apache.org/jira/browse/YARN-2740
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Naganarasimha G R
>             Fix For: 2.8.0
>
>         Attachments: YARN-2740-20141024-1.patch, YARN-2740.20150320-1.patch, 
> YARN-2740.20150327-1.patch, YARN-2740.20150411-1.patch, 
> YARN-2740.20150411-2.patch, YARN-2740.20150411-3.patch, 
> YARN-2740.20150417-1.patch, YARN-2740.20150420-1.patch, 
> YARN-2740.20150421-1.patch
>
>
> According to YARN-2495, when distributed node label configuration is enabled:
> - RMAdmin / REST API should reject change labels on node operations.
> - CommonNodeLabelsManager shouldn't persist labels on nodes when NM do 
> heartbeat.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to