[ 
https://issues.apache.org/jira/browse/YARN-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525412#comment-14525412
 ] 

Li Lu commented on YARN-3513:
-----------------------------

No I was talking about these lines in YARN-3334:
{code}
+            try {
+              TimelineClient timelineClient = context.getApplications().get(
+                  containerId.getApplicationAttemptId().getApplicationId()).
+                      getTimelineClient();
+              putEntityWithoutBlocking(timelineClient, entity);
+            }
{code}
which refs context and will have problems with
{code}
-  private final Context context;
{code}

This may be fine in trunk, but since YARN-2928 needs to merge back in near 
future, we may not want to make the change on content for now. We need to 
consider code clean up comprehensively when we're doing the branch merge. 

> Remove unused variables in ContainersMonitorImpl
> ------------------------------------------------
>
>                 Key: YARN-3513
>                 URL: https://issues.apache.org/jira/browse/YARN-3513
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 2.8.0
>
>         Attachments: YARN-3513.20150421-1.patch
>
>
> class members :  {{private final Context context;}}
> and some local variables in MonitoringThread.run()  : {{vmemStillInUsage and 
> pmemStillInUsage}} are not used and just updated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to