[
https://issues.apache.org/jira/browse/YARN-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14531917#comment-14531917
]
Li Lu commented on YARN-3513:
-----------------------------
Hi [~Naganarasimha], thanks for working on this. After looking at this patch I
have a few things to verify:
# Are we only referencing the four variables when debug is enabled? If so does
it harm to only update those four variables on debug only? I understand it may
not be quite "branch-predictor friendly", but maybe in this way we can make the
usage of those four variables more clear?
# I think we're changing the meaning of {{vmemStillInUsage}} and
{{pmemStillInUsage}}. Would you please elaborate a little bit more the current
way makes more sense than the previous way? I think the previous way only
accounts for alive containers.
> Remove unused variables in ContainersMonitorImpl
> ------------------------------------------------
>
> Key: YARN-3513
> URL: https://issues.apache.org/jira/browse/YARN-3513
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Reporter: Naganarasimha G R
> Assignee: Naganarasimha G R
> Priority: Trivial
> Labels: BB2015-05-TBR, newbie
> Attachments: YARN-3513.20150421-1.patch, YARN-3513.20150503-1.patch,
> YARN-3513.20150506-1.patch
>
>
> class members : {{private final Context context;}}
> and some local variables in MonitoringThread.run() : {{vmemStillInUsage and
> pmemStillInUsage}} are not used and just updated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
