[
https://issues.apache.org/jira/browse/YARN-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14531935#comment-14531935
]
Naganarasimha G R commented on YARN-3513:
-----------------------------------------
Thanks for reviewing [~gtCarrera9]
bq. If so does it harm to only update those four variables on debug only
+1 will do these modifications which will remove unwanted computations when
debug is not enabled
bq. I think we're changing the meaning of vmemStillInUsage and
pmemStillInUsage. Would you please elaborate a little bit more the current way
makes more sense than the previous way?
Well the names may be debatable, but my intention was to actually capture the
total usage when the monitors ran, so that it includes the usage of containers
which are about to be killled as part of monitor's run. Well can keep it as
earlier but felt this will be more useful to get the actual usage... thoughts ?
> Remove unused variables in ContainersMonitorImpl
> ------------------------------------------------
>
> Key: YARN-3513
> URL: https://issues.apache.org/jira/browse/YARN-3513
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Reporter: Naganarasimha G R
> Assignee: Naganarasimha G R
> Priority: Trivial
> Labels: BB2015-05-TBR, newbie
> Attachments: YARN-3513.20150421-1.patch, YARN-3513.20150503-1.patch,
> YARN-3513.20150506-1.patch
>
>
> class members : {{private final Context context;}}
> and some local variables in MonitoringThread.run() : {{vmemStillInUsage and
> pmemStillInUsage}} are not used and just updated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
