[ 
https://issues.apache.org/jira/browse/YARN-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14528692#comment-14528692
 ] 

Junping Du commented on YARN-3513:
----------------------------------

Sorry guys for coming with late comments. I have different opinion that we 
should make use of these unused variables instead of removing it - e.g. log in 
debug level for understanding the overall memory resource consumption across 
all running containers inside of NM. Thoughts?

> Remove unused variables in ContainersMonitorImpl
> ------------------------------------------------
>
>                 Key: YARN-3513
>                 URL: https://issues.apache.org/jira/browse/YARN-3513
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>            Priority: Trivial
>              Labels: newbie
>         Attachments: YARN-3513.20150421-1.patch, YARN-3513.20150503-1.patch
>
>
> class members :  {{private final Context context;}}
> and some local variables in MonitoringThread.run()  : {{vmemStillInUsage and 
> pmemStillInUsage}} are not used and just updated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to