Varun Saxena commented on YARN-3051:

[~zjshen], regarding the reader API patch submitted by you, and comparing it 
with the patches already submitted, some comments :

  TimelineEntity getEntity(
     String clusterId, String appId, String entityType, String entityId,
     EnumSet<Field> fieldsToRetrieve) throws IOException;

  Set<TimelineEntity> getEntities(
      String clusterId, String appId, Set<String> entityTypes, Long limit,
      Long createdTimeBegin, Long createdTimeEnd, Long modifiedTimeBegin,
      Long modifiedTimeEnd, Set<TimelineEntity.Identifier> relatesTo,
      Set<TimelineEntity.Identifier> isRelatedTo, Set<KeyValuePair> info,
      Set<KeyValuePair> configs, Set<String> events, Set<String> metrics,
      EnumSet<Field> fieldsToRetrieve) throws IOException;

* We had decided that user may not need to retrieve all the configs and metrics 
and hence we should have a parameter to indicate that ? A list of metrics and 
confs user wants to retrieve ? For both the APIs'. I had included this in the 
patch I had made. Do we need it ?
* Shouldn't we have metrics filters to support queries like fetch entities 
which have a metric > a certain value. In the patch I had included support for 
relational operators.
* A query use case for having relatesTo and isRelatedTo as filters ?
* We do not need flowId and flowRunId to get an entity. But it can still be an 
optional argument so that we avoid peek into the table which gets them based on 
cluster and appid. Thoughts ?
* Will we fetch entities across entityTypes ? We also have events as filters 
here. They may not match across entity types. Thoughts ?
* As per our previous discussion I had also included metrics time windows in 
the APIs'. This may aid in plotting graphs for long running apps. Thoughts ?

> [Storage abstraction] Create backing storage read interface for ATS readers
> ---------------------------------------------------------------------------
>                 Key: YARN-3051
>                 URL: https://issues.apache.org/jira/browse/YARN-3051
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Sangjin Lee
>            Assignee: Varun Saxena
>         Attachments: YARN-3051-YARN-2928.003.patch, 
> YARN-3051-YARN-2928.03.patch, YARN-3051-YARN-2928.04.patch, 
> YARN-3051.Reader_API.patch, YARN-3051.wip.02.YARN-2928.patch, 
> YARN-3051.wip.patch, YARN-3051_temp.patch
> Per design in YARN-2928, create backing storage read interface that can be 
> implemented by multiple backing storage implementations.

This message was sent by Atlassian JIRA

Reply via email to