Varun Saxena commented on YARN-3051:

Thanks [~zjshen] for your comments.

bq. Yeah, we could have these parameters, but I'm wondering the efficient way 
to retrieve part of the configs/metrics in a huge set. 
Makes sense. We could use a regex or club different configs into different 
groups and let user query that group. But then the problem will be how do we 
specify those groups. So as you say lets defer it and discuss it at length when 
we take it up.

bq. You give the example ">", but we need to take care of "<", "=", "!=", 
"like" and so on.
Yes we should support all relational operators. I had implemented it as well in 
the patch.  We can defer this though if we do not envisage having store 
implementations for this as of now.

bq. Personally, I prefer to defer it together with fetching particular 
configs/metrics in a later enhancement about (contents to retrieve). How do you 
Ok, lets defer it.

Overall the proposed store interface in the latest attached file LGTM. I will 
go ahead and implement it over the weekend if no further comments come.

One thing though, along the lines of patch submitted earlier, I can include 
something like {{Map<String, NameValueRelations>}} for metrics in the interface 
for specifying relational operations . It will support things like metricA>val1 
and metricA<val2 as well(means 2 conditions on the same metric to specify a 
range). Thoughts ?

> [Storage abstraction] Create backing storage read interface for ATS readers
> ---------------------------------------------------------------------------
>                 Key: YARN-3051
>                 URL: https://issues.apache.org/jira/browse/YARN-3051
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Sangjin Lee
>            Assignee: Varun Saxena
>         Attachments: YARN-3051-YARN-2928.003.patch, 
> YARN-3051-YARN-2928.03.patch, YARN-3051-YARN-2928.04.patch, 
> YARN-3051.Reader_API.patch, YARN-3051.Reader_API_1.patch, 
> YARN-3051.wip.02.YARN-2928.patch, YARN-3051.wip.patch, YARN-3051_temp.patch
> Per design in YARN-2928, create backing storage read interface that can be 
> implemented by multiple backing storage implementations.

This message was sent by Atlassian JIRA

Reply via email to