[ 
https://issues.apache.org/jira/browse/YARN-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14594067#comment-14594067
 ] 

Joep Rottinghuis commented on YARN-3051:
----------------------------------------

Thanks [~zjshen] those additional comments in javadoc explain the bigger 
picture.

A few more question that would be good to clarifiy:
{code}
120        *  @return a set of {@link TimelineEntity} instances of the given 
entity type
121        *         in the given context scope which matches the given 
predicates
122        *         ordered by created time. Each entity will only contain the 
metadata
123        *         plus the given fields to retrieve
{code}
with "matches" presumably you mean an _and_ relationship, all must be true, not 
_or_ where only one of them need to match correct?

l122 The "ordered by creation time." refers to how the optional limit is 
applied, not that we actually return an ordered set right?

{code}
118        * @param fieldsToRetrieve
118        *     the fields to be be returned (optional, by default {@link 
Field#ALL}
119        *     will be retrieved)
{code}
Probably obvious, but once ALL is specified, all fields will be returned, even 
if only some Fields are specified and others not.



> [Storage abstraction] Create backing storage read interface for ATS readers
> ---------------------------------------------------------------------------
>
>                 Key: YARN-3051
>                 URL: https://issues.apache.org/jira/browse/YARN-3051
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Sangjin Lee
>            Assignee: Varun Saxena
>         Attachments: YARN-3051-YARN-2928.003.patch, 
> YARN-3051-YARN-2928.03.patch, YARN-3051-YARN-2928.04.patch, 
> YARN-3051.Reader_API.patch, YARN-3051.Reader_API_1.patch, 
> YARN-3051.Reader_API_2.patch, YARN-3051.wip.02.YARN-2928.patch, 
> YARN-3051.wip.patch, YARN-3051_temp.patch
>
>
> Per design in YARN-2928, create backing storage read interface that can be 
> implemented by multiple backing storage implementations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to