Zhijie Shen commented on YARN-3051:

Thanks for chiming in, Jeop! Here's my reply:

bq. It is not clear in the latest patch if fully populated entities will be 

We may not need to worry about it too much. The two APIs are supposed to fetch 
the raw data. We use user Id + cluster Id + app Id + entity type to efficiently 
narrow down the scope to search for entities, and limit the number of entities 
there could be. The following optional parameters will further trim the result 

bq. If we defer being able to effectively select a subset of columns, what does 
it actually mean to specify a Set<KeyValuePair> ?
Can the value be null to indicate that we don't care what the value is and that 
means that we want the column back in the result?

I have update the javadoc to be more specify what the parameters are supposed 
to do and whether they're mandatory or optional.

bq. I'm certainly not arguing to have these HBase specific classes exposed in 
our API, but our methods should closely match what can be done, which I don't 
think will be overly restrictive or unreasonable.

I think it's a good suggestion. We should double check if we can easily map our 
customized filters can be easily mapped to some HBase filters.

Put a new patch

> [Storage abstraction] Create backing storage read interface for ATS readers
> ---------------------------------------------------------------------------
>                 Key: YARN-3051
>                 URL: https://issues.apache.org/jira/browse/YARN-3051
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Sangjin Lee
>            Assignee: Varun Saxena
>         Attachments: YARN-3051-YARN-2928.003.patch, 
> YARN-3051-YARN-2928.03.patch, YARN-3051-YARN-2928.04.patch, 
> YARN-3051.Reader_API.patch, YARN-3051.Reader_API_1.patch, 
> YARN-3051.wip.02.YARN-2928.patch, YARN-3051.wip.patch, YARN-3051_temp.patch
> Per design in YARN-2928, create backing storage read interface that can be 
> implemented by multiple backing storage implementations.

This message was sent by Atlassian JIRA

Reply via email to