[ 
https://issues.apache.org/jira/browse/YARN-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652850#comment-14652850
 ] 

Li Lu commented on YARN-3049:
-----------------------------

bq. What we discussed so far implies that we cannot only treat the entities so 
generally. For application entity, we may need to take an additional step to 
parse its start/finish event to write more records.

I'm trying to understand the discussion here. Yes, and what we worked quite 
hard to avoid is to identify the types of the incoming entities, in a writer, 
so that we can apply different write code paths. If this is the case, maybe we 
can refactor the write method so that it contains an expandable context object? 
We can easily encapsulate flags in a BitSet-like object, and we may add more if 
needed. The only problem I'm wondering about is, is it possible for the caller 
to easily generate a context with all required information (such as isNewApp or 
appFinish)? 

BTW, I believe we need to refactor the interface of the read and write methods 
to use some sorts of contexts anyways. Our current argument lists are not 
expandable. So if this helps, maybe we can move forward by refactor the write 
interfaces? 

> [Storage Implementation] Implement storage reader interface to fetch raw data 
> from HBase backend
> ------------------------------------------------------------------------------------------------
>
>                 Key: YARN-3049
>                 URL: https://issues.apache.org/jira/browse/YARN-3049
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Zhijie Shen
>         Attachments: YARN-3049-WIP.1.patch, YARN-3049-WIP.2.patch, 
> YARN-3049-WIP.3.patch, YARN-3049-YARN-2928.2.patch, 
> YARN-3049-YARN-2928.3.patch, YARN-3049-YARN-2928.4.patch, 
> YARN-3049-YARN-2928.5.patch
>
>
> Implement existing ATS queries with the new ATS reader design.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to