[ 
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14903342#comment-14903342
 ] 

Li Lu commented on YARN-4075:
-----------------------------

Hi [~varun_saxena], thanks for the note! 

bq. Infact in initial patches in YARN-3814 I was taking cluster ID from config 
if it was not supplied by user i.e. it was an optional query parameter. But 
Zhijie was of the opinion that this handling should be done at TimelineClient 
side and that is what seemed to be the consensus at that time. Hence I removed 
it.
Sure. However at that time we did not think about web apps. It will be a little 
bit non-trivial for front-end web page to figure out which cluster it's 
pointing to without user input. I noticed in the discussion you raised a quite 
helpful point:
bq. Or we can have 2 separate REST endpoints, with and without cluster ID.
This looks good to me. Are there any specific challenges to implement this? 

bq. For ordering should we change the set inside TimelineEntities to TreeSet 
with comparator based on created time ? 
Let's not enforce an order by default since this may be slightly more 
expensive? The programmer can always sort them on the client side if needed. 

bq. I plan to combine to test webservices classes to use HBase
The UTs on webservices should be independent from the storage implementations. 
However we do have problems with supporting more features with the old fs 
storage, so yes it's fine to make the change here. Maybe we'd like to mark them 
as test only? 

> [reader REST API] implement support for querying for flows and flow runs
> ------------------------------------------------------------------------
>
>                 Key: YARN-4075
>                 URL: https://issues.apache.org/jira/browse/YARN-4075
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Sangjin Lee
>            Assignee: Varun Saxena
>         Attachments: YARN-4075-YARN-2928.POC.1.patch, 
> YARN-4075-YARN-2928.POC.2.patch
>
>
> We need to be able to query for flows and flow runs via REST.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to