Varun Saxena commented on YARN-4075:

Or we can have 2 separate REST endpoints, with and without cluster ID.
This looks good to me. Are there any specific challenges to implement this?
This can lead to code bloating with similar methods repeating again and again. 
Otherwise no other concern. I had tried doing a regex match for paths at the 
time. But that doesn't seem to work if matching path is not in the end which in 
case of cluster ID wont be.

Let's not enforce an order by default since this may be slightly more 
expensive? The programmer can always sort them on the client side if needed.
Well currently the entities are returned in order, sorted by created time. That 
is how we have documented our reader API as well. TimelineReader#getEntities is 
supposed to return entities sorted descendingly by created time. We will be 
breaking this behavior if we use TimelineEntities and do not change the set 

However we do have problems with supporting more features with the old fs 
storage, so yes it's fine to make the change here. Maybe we'd like to mark them 
as test only?
You want me to do this refactoring in this JIRA ? I think I can handle this 
refactoring alongside some other JIRA. And we can get this in ASAP for UI 
related work. 

Will rebase it and update the patch tomorrow morning India time. I think 4074 
should be in by then. 

> [reader REST API] implement support for querying for flows and flow runs
> ------------------------------------------------------------------------
>                 Key: YARN-4075
>                 URL: https://issues.apache.org/jira/browse/YARN-4075
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Sangjin Lee
>            Assignee: Varun Saxena
>         Attachments: YARN-4075-YARN-2928.POC.1.patch, 
> YARN-4075-YARN-2928.POC.2.patch
> We need to be able to query for flows and flow runs via REST.

This message was sent by Atlassian JIRA

Reply via email to