Varun Saxena commented on YARN-4075:

bq. With proper overloading I don't see significant code duplication problems.
Yeah there aren't too many code duplication problems. Its just that the methods 
have so many parameters that this itself looks quite big. Anyways thats not a 
major issue.

bq. TimelineEntities is not only used by the reader. It is also used by the 
writer and aggregation logic. Enforcing an order on this class will introduce 
unnecessary overhead to both writers and aggregators. If the reader needs it, 
we should derive it and make an ordered version, if possible.
Yes thats a fair point. We can use setEntities on the read path. Explicitly 
defining a derived class for readers might be an option as well(say something 
like SortedTimelineEntities). I think we should make this return type explicit 
so that reader implementations use it.

> [reader REST API] implement support for querying for flows and flow runs
> ------------------------------------------------------------------------
>                 Key: YARN-4075
>                 URL: https://issues.apache.org/jira/browse/YARN-4075
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Sangjin Lee
>            Assignee: Varun Saxena
>         Attachments: YARN-4075-YARN-2928.POC.1.patch, 
> YARN-4075-YARN-2928.POC.2.patch
> We need to be able to query for flows and flow runs via REST.

This message was sent by Atlassian JIRA

Reply via email to