[ https://issues.apache.org/jira/browse/YARN-4169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14904178#comment-14904178 ]
Steve Loughran commented on YARN-4169: -------------------------------------- I'm not the person to review YARN patches, I'm afraid. Looking at the tests briefly # you can use Java 7 <> tags in constructors; the old code was for java 6 and can be upgraded on the changed lines. # no need to catch InterruptedExceptions and {{AssertFail()}}. Simply have the test declare it throws {{InterruptedException}} and JUnit will do the rest. > jenkins trunk+java build failed in TestNodeStatusUpdaterForLabels > ----------------------------------------------------------------- > > Key: YARN-4169 > URL: https://issues.apache.org/jira/browse/YARN-4169 > Project: Hadoop YARN > Issue Type: Bug > Components: test > Affects Versions: 3.0.0 > Environment: Jenkins > Reporter: Steve Loughran > Assignee: Naganarasimha G R > Priority: Critical > Attachments: YARN-4169.v1.001.patch > > > Test failing in [[Jenkins build > 402|https://builds.apache.org/view/H-L/view/Hadoop/job/Hadoop-Yarn-trunk-Java8/402/testReport/junit/org.apache.hadoop.yarn.server.nodemanager/TestNodeStatusUpdaterForLabels/testNodeStatusUpdaterForNodeLabels/] > {code} > java.lang.NullPointerException: null > at java.util.HashSet.<init>(HashSet.java:118) > at > org.apache.hadoop.yarn.nodelabels.NodeLabelTestBase.assertNLCollectionEquals(NodeLabelTestBase.java:103) > at > org.apache.hadoop.yarn.server.nodemanager.TestNodeStatusUpdaterForLabels.testNodeStatusUpdaterForNodeLabels(TestNodeStatusUpdaterForLabels.java:268) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)