Steve Loughran commented on YARN-4169:

# If there is a way to query the state of the updater, then that is better to 
block on. If there isn't a way to query it, then maybe a way to check the 
status should be provided (e.g some AtomicBoolean).
# Even so, what we have here should be better than before? How about we start 
with this patch (with some minor changes) and then see how well it works?

Two needed changes
# {{timeout=}} attribute in the @Test.
# lower-case "l" values in Long integers are considered dangerous; better to 
have {{50L}} over {{50l}}, because the latter can look like 501 in some fonts. 
In {{Thread.sleep}} we can just have {{50}} without worrying about the L value 
at all

> jenkins trunk+java build failed in TestNodeStatusUpdaterForLabels
> -----------------------------------------------------------------
>                 Key: YARN-4169
>                 URL: https://issues.apache.org/jira/browse/YARN-4169
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.0.0
>         Environment: Jenkins
>            Reporter: Steve Loughran
>            Assignee: Naganarasimha G R
>            Priority: Critical
>         Attachments: YARN-4169.v1.001.patch, YARN-4169.v1.002.patch
> Test failing in [[Jenkins build 
> 402|https://builds.apache.org/view/H-L/view/Hadoop/job/Hadoop-Yarn-trunk-Java8/402/testReport/junit/org.apache.hadoop.yarn.server.nodemanager/TestNodeStatusUpdaterForLabels/testNodeStatusUpdaterForNodeLabels/]
> {code}
> java.lang.NullPointerException: null
>       at java.util.HashSet.<init>(HashSet.java:118)
>       at 
> org.apache.hadoop.yarn.nodelabels.NodeLabelTestBase.assertNLCollectionEquals(NodeLabelTestBase.java:103)
>       at 
> org.apache.hadoop.yarn.server.nodemanager.TestNodeStatusUpdaterForLabels.testNodeStatusUpdaterForNodeLabels(TestNodeStatusUpdaterForLabels.java:268)
> {code}

This message was sent by Atlassian JIRA

Reply via email to