[
https://issues.apache.org/jira/browse/YARN-4169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14959374#comment-14959374
]
Naganarasimha G R commented on YARN-4169:
-----------------------------------------
Thanks [[email protected]] for pointing this issue in yarn-dev and [~wangda]
for the comments.
[~wangda] though initially me and Rohith thought about a similar approach we
did not go for it as it was a critical path and we did not want to hold a
synchronization locks just for the purpose of test case.
Yes the approach you mentioned greatly simplifies the test case but may be we
need to still wait for very first heartbeat to be completed and then we try to
call {{doStatusUpdate}} to *avoid race conditions between them to set the
NodeLabels*. so may be it will not completely solve the problem as we need some
approach to identify first HB is over and thread is waiting. Also the current
approach taken seems to solve the issue.
Besides as explained in earlier
[comment|https://issues.apache.org/jira/browse/YARN-4169?focusedCommentId=14933149&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14933149]
i feel the behavior of {{NodeStatusUpdaterImpl.sendOutofBandHeartBeat}} is not
appropriate, your thoughts on it ?
> jenkins trunk+java build failed in TestNodeStatusUpdaterForLabels
> -----------------------------------------------------------------
>
> Key: YARN-4169
> URL: https://issues.apache.org/jira/browse/YARN-4169
> Project: Hadoop YARN
> Issue Type: Bug
> Components: test
> Affects Versions: 3.0.0
> Environment: Jenkins
> Reporter: Steve Loughran
> Assignee: Naganarasimha G R
> Priority: Critical
> Attachments: YARN-4169.v1.001.patch, YARN-4169.v1.002.patch,
> YARN-4169.v1.003.patch
>
>
> Test failing in [[Jenkins build
> 402|https://builds.apache.org/view/H-L/view/Hadoop/job/Hadoop-Yarn-trunk-Java8/402/testReport/junit/org.apache.hadoop.yarn.server.nodemanager/TestNodeStatusUpdaterForLabels/testNodeStatusUpdaterForNodeLabels/]
> {code}
> java.lang.NullPointerException: null
> at java.util.HashSet.<init>(HashSet.java:118)
> at
> org.apache.hadoop.yarn.nodelabels.NodeLabelTestBase.assertNLCollectionEquals(NodeLabelTestBase.java:103)
> at
> org.apache.hadoop.yarn.server.nodemanager.TestNodeStatusUpdaterForLabels.testNodeStatusUpdaterForNodeLabels(TestNodeStatusUpdaterForLabels.java:268)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
