Naganarasimha G R commented on YARN-4169:

Thanks for the comments [~rohithsharma] & [~steve_l], 
Uploading a patch with incorporating both of your comments.
bq.  If wants to check NodeStausUpdator is in waiting state, probably can get 
thread state OR wait for thread state.
Yes this would be a better option as it would be more deterministic, thanks for 
the approach. 

But in general i think this is not just test case issue but also issue with 
{{NodeStatusUpdaterImpl.sendOutofBandHeartBeat}} which is not only called by 
the Testcases but also when *container is killed*. Suppose in large cluster we 
have HB as 5 seconds and when current call is in progress then call to 
{{sendOutofBandHeartBeat}} has no impact and the information of completed 
container is not shared till the next interval. So in my opinion 
sendOutofBandHeartBeat should return {{boolean}} informing the caller weather 
its successfull or not and also we can support some additional logic to push 
NM's HB earlier than the interval suggested by RM when outOfBandHB was not 
successful. Thoughts ? 

> jenkins trunk+java build failed in TestNodeStatusUpdaterForLabels
> -----------------------------------------------------------------
>                 Key: YARN-4169
>                 URL: https://issues.apache.org/jira/browse/YARN-4169
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.0.0
>         Environment: Jenkins
>            Reporter: Steve Loughran
>            Assignee: Naganarasimha G R
>            Priority: Critical
>         Attachments: YARN-4169.v1.001.patch, YARN-4169.v1.002.patch
> Test failing in [[Jenkins build 
> 402|https://builds.apache.org/view/H-L/view/Hadoop/job/Hadoop-Yarn-trunk-Java8/402/testReport/junit/org.apache.hadoop.yarn.server.nodemanager/TestNodeStatusUpdaterForLabels/testNodeStatusUpdaterForNodeLabels/]
> {code}
> java.lang.NullPointerException: null
>       at java.util.HashSet.<init>(HashSet.java:118)
>       at 
> org.apache.hadoop.yarn.nodelabels.NodeLabelTestBase.assertNLCollectionEquals(NodeLabelTestBase.java:103)
>       at 
> org.apache.hadoop.yarn.server.nodemanager.TestNodeStatusUpdaterForLabels.testNodeStatusUpdaterForNodeLabels(TestNodeStatusUpdaterForLabels.java:268)
> {code}

This message was sent by Atlassian JIRA

Reply via email to