Wangda Tan commented on YARN-4162:

Thanks [~Naganarasimha] working on this! Sample REST response generally looks 
good, some comments: 

1) Suggest to rename ResourceUsageInfo.partitionResourceUsages to 
resourceUsagesByPartition. Similarly, 
QueueCapacitiesInfo.partitionQueueCapacity -> queueCapacitiesByPartition
2) I think pendingResource/amResource is also very important for 
user/leafQueue's resourceUsage.
3) I think it's better to move 
CapacitySchedulerInfo#getResourceUsageInfo/getQueueCapacitiesInfo to 
ResourceUsage#createResourceUsageInfo and 
QueueCapacities#createQueueCapacitiesInfo. With this, you can access internal 
fields of ResourceUsage/QueueCapacities and it will be more nature to me to 
create -Info from a class.

Will include more detailed code review at next iteration.

> Scheduler info in REST, is currently not displaying partition specific queue 
> information similar to UI
> ------------------------------------------------------------------------------------------------------
>                 Key: YARN-4162
>                 URL: https://issues.apache.org/jira/browse/YARN-4162
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api, client, resourcemanager
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>         Attachments: YARN-4162.v1.001.patch, YARN-4162.v2.001.patch, 
> YARN-4162.v2.002.patch, restAndJsonOutput.zip
> When Node Labels are enabled then REST Scheduler Information should also 
> provide partition specific queue information similar to the existing Web UI

This message was sent by Atlassian JIRA

Reply via email to