Wangda Tan commented on YARN-4162:

bq. well i can avoid the if block but csqinfo.label itself cannot be set to the 
default Partition as its also been used as flag to determine to show the leaf 
queue in the normal way or the partition way.
I think it's fine if there's no regression for existing UI.

bq. isExclusiveNodeLabel is the check we had earlier in 
CapacitySchedulerInfo.getQueues, basically to avoid displaying the queues which 
is not accessible to a given NodeLabelPartition.
Make sense, I can remember that now :)

bq. Well shall i update in all places displayed in UI or only in REST ?
It's not necessary to update all places, but if all web UI is using a same 
final field, they will be updated automatically.
And I think if {{<...>}} is removed, we need a separated JIRA to node labels 
manager and client to make sure "DEFAULT_PARTITION" is a reserved partition 
name that no one should add/remove or use it (you cannot say I want to 
associate one node to the "DEFAULT_PARTITION").
What do you think?

> Scheduler info in REST, is currently not displaying partition specific queue 
> information similar to UI
> ------------------------------------------------------------------------------------------------------
>                 Key: YARN-4162
>                 URL: https://issues.apache.org/jira/browse/YARN-4162
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api, client, resourcemanager
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>         Attachments: YARN-4162.v1.001.patch, YARN-4162.v2.001.patch, 
> YARN-4162.v2.002.patch, YARN-4162.v2.003.patch, restAndJsonOutput.zip
> When Node Labels are enabled then REST Scheduler Information should also 
> provide partition specific queue information similar to the existing Web UI

This message was sent by Atlassian JIRA

Reply via email to