[
https://issues.apache.org/jira/browse/YARN-4162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14949658#comment-14949658
]
Wangda Tan commented on YARN-4162:
----------------------------------
[~Naganarasimha],
Thanks a lot for updating! Looked at patch and tried it locally, some minor
comments:
1. UserInfo#getResources -> getResourceUsageInfo
2. CapacitySchedulerPage, renderQueueCapacityInfo can be removed? Is it
equivalent if using renderQueueCapacityInfo(ri, lqinfo.get(DEFAULT_PARTITION))
instead?
3. Also,
For
{code}
UL<Hamlet> ul = html.ul("#pq");
for (CapacitySchedulerQueueInfo info : subQueues) {
float used;
float absCap;
float absMaxCap;
float absUsedCap;
//...
{code}
Is it possible to use the same PartitionQueueCapacitiesInfo instead of check if
csqinfo.label == null or not?
4. PartitionResourceUsageInfo.amResource -> amUsed
5. Why this isExclusiveNodeLabel check is needed?
{code}
if (!nodeLabel.equals(NodeLabel.DEFAULT_NODE_LABEL_PARTITION)
&& csqinfo.isExclusiveNodeLabel
{code}
6. Could you update {{<DEFAULT_PARTITION>}} to {{DEFAULT_PARTITION}}? Since the
{{< ... >}} could be a illegal attribute for some xml parser, and I'm not sure
if it is a standard XML property.
> Scheduler info in REST, is currently not displaying partition specific queue
> information similar to UI
> ------------------------------------------------------------------------------------------------------
>
> Key: YARN-4162
> URL: https://issues.apache.org/jira/browse/YARN-4162
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: api, client, resourcemanager
> Reporter: Naganarasimha G R
> Assignee: Naganarasimha G R
> Attachments: YARN-4162.v1.001.patch, YARN-4162.v2.001.patch,
> YARN-4162.v2.002.patch, YARN-4162.v2.003.patch, restAndJsonOutput.zip
>
>
> When Node Labels are enabled then REST Scheduler Information should also
> provide partition specific queue information similar to the existing Web UI
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
