Wangda Tan commented on YARN-3216:

bq. In FiCaSchedulerApp's ctor, update AM-Resource-Request.resource on 
partition ( keep existing code). But use 
rmApp.getAMResourceRequest().getNodeLabelExpression() to setAMResource instead 
of setting to NO_LABEL. Because this information wont be changed later.
Make sense to me.

bq. Here AM-Resource-Request.resource is updated in FiCaSchedulerApp's ctor 
based on rmApp.getAMResourceRequest. Once container is allocated, this resource 
will be come a part of the partition with no change in resource. So I feel I 
need not have to update resource in allocate call of FicaSchedulerApp. Am I 
I think so, maybe we need to consider increase container also, but I think it's 
an edge case, we may or may not need to handle it.

> Max-AM-Resource-Percentage should respect node labels
> -----------------------------------------------------
>                 Key: YARN-3216
>                 URL: https://issues.apache.org/jira/browse/YARN-3216
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Sunil G
>            Priority: Critical
>         Attachments: 0001-YARN-3216.patch, 0002-YARN-3216.patch, 
> 0003-YARN-3216.patch
> Currently, max-am-resource-percentage considers default_partition only. When 
> a queue can access multiple partitions, we should be able to compute 
> max-am-resource-percentage based on that.

This message was sent by Atlassian JIRA

Reply via email to