[
https://issues.apache.org/jira/browse/YARN-3216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14954269#comment-14954269
]
Sunil G commented on YARN-3216:
-------------------------------
Hi [~leftnoteasy]
Thank you for sharing the comments.
bq.why computing max of queue's max resource and configured resource?
I have one scenario here. When a queue capacity is 0.1 and max capacity is 1.0,
it can use complete resources in cluster. So if all nodes are with NO_LABEL, we
can take all nodes of applications running in this queue (best case scenario).
So max-capacity will be helpful here, and as I see it {{getAMResourceLimit()}}
is having this also considered.
{code}
synchronized (queueResourceLimitsInfo) {
queueCurrentLimit = queueResourceLimitsInfo.getQueueCurrentLimit();
}
Resource queueCap = Resources.max(resourceCalculator, lastClusterResource,
absoluteCapacityResource, queueCurrentLimit);
{code}
Am I missing something, please correct me if I am wrong.
bq.getUserAMResourceLimit should consider partition as well
As suggested in an earlier comment, I created a JIRA to track
user-am-resource-limit per-partition separately. YARN-4229. I will link the
issue here.
I will address all the other comments in next patch.
> Max-AM-Resource-Percentage should respect node labels
> -----------------------------------------------------
>
> Key: YARN-3216
> URL: https://issues.apache.org/jira/browse/YARN-3216
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Wangda Tan
> Assignee: Sunil G
> Priority: Critical
> Attachments: 0001-YARN-3216.patch, 0002-YARN-3216.patch,
> 0003-YARN-3216.patch, 0004-YARN-3216.patch, 0005-YARN-3216.patch,
> 0006-YARN-3216.patch
>
>
> Currently, max-am-resource-percentage considers default_partition only. When
> a queue can access multiple partitions, we should be able to compute
> max-am-resource-percentage based on that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
