[
https://issues.apache.org/jira/browse/YARN-3216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14954006#comment-14954006
]
Wangda Tan commented on YARN-3216:
----------------------------------
Hi Sunil,
Thanks for update, some questions/comments:
1) getAMResourceLimitPerPartition: why computing max of queue's max resource
and configured resource?
{code}
...
Resources.max(resourceCalculator,
lastClusterResource, queueMaxResource, partitionCapacity),
...
{code}
I think partitionCapacity should be enough.
And some naming suggestions:
- partitionCapacity -> queuePartitionResource, "capacity" means the percentage
of capacity in most of CS logic.
2) getUserAMResourceLimit should consider partition as well? I think we should
use getAMResourceLimitPerPartition to get userAMResourceLimitPerPartition.
3) If you agree with 2), getAMResourceLimit and getUserAMResourceLimit is used
by test/REST-API only, I think we need to remove then and use the
get(User)AMLimitPerPartition instead.
4) Could you give a default am-label value to MockRM.submitApp, which could
avoid some test code changes.
5) Suggest to add new tests to a new file such as
TestApplicationLimitsByPartition. TestNodeLabelContainerAllocation is used to
test container allocation behavior. And could you add more corner case tests,
such as less than one application activated in a queue / by default partition'
am-percent is queue's am-percent, etc.
> Max-AM-Resource-Percentage should respect node labels
> -----------------------------------------------------
>
> Key: YARN-3216
> URL: https://issues.apache.org/jira/browse/YARN-3216
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Wangda Tan
> Assignee: Sunil G
> Priority: Critical
> Attachments: 0001-YARN-3216.patch, 0002-YARN-3216.patch,
> 0003-YARN-3216.patch, 0004-YARN-3216.patch, 0005-YARN-3216.patch,
> 0006-YARN-3216.patch
>
>
> Currently, max-am-resource-percentage considers default_partition only. When
> a queue can access multiple partitions, we should be able to compute
> max-am-resource-percentage based on that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
