[
https://issues.apache.org/jira/browse/YARN-3216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14951423#comment-14951423
]
Wangda Tan commented on YARN-3216:
----------------------------------
Hi [~sunilg],
I think the changes to AbstractCSQueue may not be necessary, could you take a
look at my previous comment (copied here) and let me know your thoughts?
bq. AbstractCSQueue: Instead of adding AM-used-resource to parentQueue, I think
we may only need to calculate AM-used-resource on LeafQueueu and user.
Currently we don't have limitation of AM-used-resource on parentQueue, so the
aggregated resource may not be very useful. We can add it along the hierachy if
we want to limit max-am-percent on parentQueue in the future.
If max-am-percent for queue-partitions isn't set, I think it should use
queue.max-am-percent instead of 0 to avoid painful of configuration. (admin has
to set max-am-percent after add a new partition)
I found the logic in your patch is: if max-am-percent for partition-x is not
set, partition-x's am-limit equals to default-partition's am-limit, which is
not correct to me. am-limit under each partition should be calculated
independently, since total resource for different partitions varies.
If you agree, could you merge the am-limit computation logic of default
partition and specific partition?
Thoughts?
Thanks,
> Max-AM-Resource-Percentage should respect node labels
> -----------------------------------------------------
>
> Key: YARN-3216
> URL: https://issues.apache.org/jira/browse/YARN-3216
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Wangda Tan
> Assignee: Sunil G
> Priority: Critical
> Attachments: 0001-YARN-3216.patch, 0002-YARN-3216.patch,
> 0003-YARN-3216.patch, 0004-YARN-3216.patch
>
>
> Currently, max-am-resource-percentage considers default_partition only. When
> a queue can access multiple partitions, we should be able to compute
> max-am-resource-percentage based on that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
