[ 
https://issues.apache.org/jira/browse/YARN-3216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14960057#comment-14960057
 ] 

Sunil G commented on YARN-3216:
-------------------------------

Thank you [~leftnoteasy] for the comments.
bq.Otherwise, a queue has max-capacity >> configured-capacity will be 
problematic
I also wanted to use queue-limit computation for node partition at first. Yes, 
for now we can use queue-configured-capacity which is been already handled with 
cachedHeadroom in queue level. This can almost match our usecase. and I feel I 
can file a ticket to handle queue-limit computation for node partition. 
Thoughts?

bq.For the userAMCheck, I think we should be able to allocate at least one AM 
container in the partition, correct? Just like what you did to queue:
Yes. We just need that one check to handle user-am-limit. I will close 
YARN-4229 as Wont Fix as we are already handling this here.

I will submit patch with test cases modifications as suggested.

> Max-AM-Resource-Percentage should respect node labels
> -----------------------------------------------------
>
>                 Key: YARN-3216
>                 URL: https://issues.apache.org/jira/browse/YARN-3216
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Sunil G
>            Priority: Critical
>         Attachments: 0001-YARN-3216.patch, 0002-YARN-3216.patch, 
> 0003-YARN-3216.patch, 0004-YARN-3216.patch, 0005-YARN-3216.patch, 
> 0006-YARN-3216.patch, 0007-YARN-3216.patch
>
>
> Currently, max-am-resource-percentage considers default_partition only. When 
> a queue can access multiple partitions, we should be able to compute 
> max-am-resource-percentage based on that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to