Sangjin Lee commented on YARN-4179:

>From the user's point of view, I think it makes the most sense to use a date 
>format and assume GMT.

In terms of tying it back to the flow activity record, we should be able to use 
the times coming from the user and converted with the date format, right? We 
just need to ensure it agrees with the "top-of-the-day" method we have so that 
if the user provided the right date it would select the records with that date.

I'll go over the patch in more detail, but I noticed that we're introducing a 
new dependency for date parsing (commons-lang3). Is that necessary? Can this be 
accomplished with the existing JDK API and the old commons-lang? What is the 

> [reader implementation] support flow activity queries based on time
> -------------------------------------------------------------------
>                 Key: YARN-4179
>                 URL: https://issues.apache.org/jira/browse/YARN-4179
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Sangjin Lee
>            Assignee: Varun Saxena
>            Priority: Minor
>         Attachments: YARN-4179-YARN-2928.01.patch
> This came up as part of YARN-4074 and YARN-4075.
> Currently the only query pattern that's supported on the flow activity table 
> is by cluster only. But it might be useful to support queries by cluster and 
> certain date or dates.

This message was sent by Atlassian JIRA

Reply via email to