[
https://issues.apache.org/jira/browse/YARN-4179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14966200#comment-14966200
]
Sangjin Lee commented on YARN-4179:
-----------------------------------
The latest patch looks pretty good. Only a couple of minor comments.
(TimelineReaderWebServices.java)
- l.125: nit: "daterange" -> "date range" (a couple of other places too)
- l.123-140: I'm pretty sure the logic is correct and does what we intend, but
it could use some comments to make it easier to read later. For example,
l.138-139 could have the comment that says it is dealing with the case where a
single date (without "-") was specified, and so on.
> [reader implementation] support flow activity queries based on time
> -------------------------------------------------------------------
>
> Key: YARN-4179
> URL: https://issues.apache.org/jira/browse/YARN-4179
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Affects Versions: YARN-2928
> Reporter: Sangjin Lee
> Assignee: Varun Saxena
> Priority: Minor
> Attachments: YARN-4179-YARN-2928.01.patch,
> YARN-4179-YARN-2928.02.patch
>
>
> This came up as part of YARN-4074 and YARN-4075.
> Currently the only query pattern that's supported on the flow activity table
> is by cluster only. But it might be useful to support queries by cluster and
> certain date or dates.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
