Varun Saxena commented on YARN-4179:

Typos in my first comment so writing it again.
bq. As I mentioned in an earlier comment, can we simply use JDK's date 
formatter for this? It would be good to avoid adding a new dependency unless it 
is absolutely necessary.
JAVAs' SimpleDateFormat is not thread safe. Apache commons-lang's 
FastDateFormat claims to be 25% faster too. Used commons-lang3 because 
commons-lang's FastDateFormat does not provide date parsing capability. If you 
want to avoid adding a dependency and we have decided to use a single date 
format(yyyyMMdd), I can write a custom method to do date parsing as well and 
convert it into seconds since epoch.

> [reader implementation] support flow activity queries based on time
> -------------------------------------------------------------------
>                 Key: YARN-4179
>                 URL: https://issues.apache.org/jira/browse/YARN-4179
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Sangjin Lee
>            Assignee: Varun Saxena
>            Priority: Minor
>         Attachments: YARN-4179-YARN-2928.01.patch
> This came up as part of YARN-4074 and YARN-4075.
> Currently the only query pattern that's supported on the flow activity table 
> is by cluster only. But it might be useful to support queries by cluster and 
> certain date or dates.

This message was sent by Atlassian JIRA

Reply via email to