Varun Saxena commented on YARN-4179:

bq. There are ways to handle this easily without incurring synchronization 
overhead however.
Hmm...I see. Although FastDateFormat claims to be faster in all possible cases 
of using SimpleDateFormat but this is unlikely to be a bottleneck in our case 
especially while using ThreadLocal. Will change.

bq. We can discuss whether it's worth supporting them.
Yeah we can discuss regarding them. 
What I was thinking was not to make them open ended(albeit the patch missed 
some sanity checks). But on second thoughts, I think keeping it open ended with 
limits maybe fine as you said. Now the question comes should we then have a 
daterange like "-20151001" or support 2 query params. Will go with former as of 
Some additional checks(in addition to what you mentioned) are needed in the 
patch including whether date is in correct format or not. I think if we set 
SimpleDateFormat#setLenient as false, that will be taken care. 
Will upload a patch with changes for further review.

> [reader implementation] support flow activity queries based on time
> -------------------------------------------------------------------
>                 Key: YARN-4179
>                 URL: https://issues.apache.org/jira/browse/YARN-4179
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Sangjin Lee
>            Assignee: Varun Saxena
>            Priority: Minor
>         Attachments: YARN-4179-YARN-2928.01.patch
> This came up as part of YARN-4074 and YARN-4075.
> Currently the only query pattern that's supported on the flow activity table 
> is by cluster only. But it might be useful to support queries by cluster and 
> certain date or dates.

This message was sent by Atlassian JIRA

Reply via email to