[ 
https://issues.apache.org/jira/browse/YARN-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15039502#comment-15039502
 ] 

Jian He commented on YARN-4403:
-------------------------------

patch looks good to me. 
one minor suggestion, do you think we can change the base 
AbstractLivelinessMonitor to have a default constructor with   MonotonicClock 
and callers can use this constructor instead ?

> (AM/NM/Container)LivelinessMonitor should use monotonic time when calculating 
> period
> ------------------------------------------------------------------------------------
>
>                 Key: YARN-4403
>                 URL: https://issues.apache.org/jira/browse/YARN-4403
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Junping Du
>            Assignee: Junping Du
>            Priority: Critical
>         Attachments: YARN-4403.patch
>
>
> Currently, (AM/NM/Container)LivelinessMonitor use current system time to 
> calculate a duration of expire which could be broken by settimeofday. We 
> should use Time.monotonicNow() instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to