[ https://issues.apache.org/jira/browse/YARN-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15046961#comment-15046961 ]
Sunil G commented on YARN-4403: ------------------------------- Hi [~djp] Thanks for the updated patch. I have one doubt here, we could see tat {{SystemClock#getTime}} is *Public* and *Stable*. Now there is a note saying that its advisable to use {{MonotonicClock}}, so any annotation change is needed for {{SystemClock}}? > (AM/NM/Container)LivelinessMonitor should use monotonic time when calculating > period > ------------------------------------------------------------------------------------ > > Key: YARN-4403 > URL: https://issues.apache.org/jira/browse/YARN-4403 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Junping Du > Assignee: Junping Du > Priority: Critical > Attachments: YARN-4403-v2.patch, YARN-4403.patch > > > Currently, (AM/NM/Container)LivelinessMonitor use current system time to > calculate a duration of expire which could be broken by settimeofday. We > should use Time.monotonicNow() instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332)