[ https://issues.apache.org/jira/browse/YARN-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15041446#comment-15041446 ]
Junping Du commented on YARN-4403: ---------------------------------- Thanks Jian for review and comments. My first thought before is to replace {{AbstractLivelinessMonitor(String name, Clock clock)}} with {{AbstractLivelinessMonitor(String name)}} with MonotonicClock as default. However, we have {{TestAMLivelinessMonitor#testResetTimer}} need to set ControlledClock instead of SystemClock/MonotonicClock for test logic that means caller could use clock parameter in future for test purpose. May be we should keep current constructor there for more flexibility from caller? > (AM/NM/Container)LivelinessMonitor should use monotonic time when calculating > period > ------------------------------------------------------------------------------------ > > Key: YARN-4403 > URL: https://issues.apache.org/jira/browse/YARN-4403 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Junping Du > Assignee: Junping Du > Priority: Critical > Attachments: YARN-4403.patch > > > Currently, (AM/NM/Container)LivelinessMonitor use current system time to > calculate a duration of expire which could be broken by settimeofday. We > should use Time.monotonicNow() instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332)