Naganarasimha G R commented on YARN-2934:

[~jira.shegalov] thanks for the comments,

bq. good to see the patch lose 3kb, most of all there are no more changes to 
the common Configuration class.

bq. Still don't see any value in this, please drop: ??if (listStatus.length > 
1) ....??
I placed it as i understood your comment ??Not sure how fancy we need to be 
with the case where multiple log files qualify for the pattern, but maybe at 
least mention to the user there are more files to look at.?? in this way. But 
felt its better to have a log than showing it in the diagnostic msg , thoughts ?

bq. We can FileUtil.stat2Paths or add a loop here to extract just the last path 
Going by the propability, in most of the cases there will be only one error 
file matching the pattern, in that case  based on your earlier approach which 
you had suggested will repeat the name of the file twice, which i felt 
redundant hence removed it. Message would look something like :
Container exited with a non-zero exit code 127. Error file(s): [error.log]
Last 4096 bytes of error.log :
/bin/bash: /no/jvm/here/bin/java: No such file or directory
Please share your thoughts if required can add it  and for other comments i am 
working on it .

> Improve handling of container's stderr 
> ---------------------------------------
>                 Key: YARN-2934
>                 URL: https://issues.apache.org/jira/browse/YARN-2934
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Gera Shegalov
>            Assignee: Naganarasimha G R
>            Priority: Critical
>         Attachments: YARN-2934.v1.001.patch, YARN-2934.v1.002.patch, 
> YARN-2934.v1.003.patch, YARN-2934.v1.004.patch, YARN-2934.v1.005.patch, 
> YARN-2934.v1.006.patch, YARN-2934.v1.007.patch, YARN-2934.v1.008.patch, 
> YARN-2934.v2.001.patch
> Most YARN applications redirect stderr to some file. That's why when 
> container launch fails with {{ExitCodeException}} the message is empty.

This message was sent by Atlassian JIRA

Reply via email to