Naganarasimha G R commented on YARN-5697:

Thanks for the latest patch and most of it seems fine with me
# would like to see some test cases to see the client processing are correct by 
test class overridden RMAdminCLI.createAdminProtocol() and verify diff 
combination of inputs for handleReplaceLabelsOnNodes. as earlier i was able to 
see test case passing but the nodeid coming as invalid.
# wouldn't it be better to use {{cliParser.getOptionValues}} rather than 
{{remainArgs = cliParser.getArgs()}} and then check it ? then we need to keep 
the label mappings as command option values and additional options at the last 
which i feel is fine. If we take this approach accordingly we need to update 
usage command for replace. If agree then we need to handle in all other places 

> Use CliParser to parse options in RMAdminCLI
> --------------------------------------------
>                 Key: YARN-5697
>                 URL: https://issues.apache.org/jira/browse/YARN-5697
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.8.0
>            Reporter: Tao Jie
>            Assignee: Tao Jie
>             Fix For: 2.8.0
>         Attachments: YARN-5697.001.patch, YARN-5697.002.patch, 
> YARN-5697.003.patch
> As discussed in YARN-4855, it is better to use CliParser rather than args to 
> parse command line options in RMAdminCli.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to