[
https://issues.apache.org/jira/browse/YARN-5697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15565416#comment-15565416
]
Tao Jie commented on YARN-5697:
-------------------------------
Thank you [~Naganarasimha] for your comments.
As I mentioned before, I tried {{cliParser.getOptionValues}} in the earlier
patch but found incompatibility. Both {{rmadmin -replaceLabelsOnNode
node1=label1 -directlyAccessNodeLabelStore}} and {{rmadmin -replaceLabelsOnNode
-directlyAccessNodeLabelStore node1=label1}} go well in existing logic. When I
use {{cliParser.getOptionValues}} to parse the latter command, {{node1=label1}}
is parsed as optionValue of {{-directlyAccessNodeLabelStore}} rather than
{{-replaceLabelsOnNode}}. Actually {{-directlyAccessNodeLabelStore}} is valid
in any position. As a result I use {{cliParser.getArgs()}}, which ignores args
sequence but keep compatible with existing logic.
> Use CliParser to parse options in RMAdminCLI
> --------------------------------------------
>
> Key: YARN-5697
> URL: https://issues.apache.org/jira/browse/YARN-5697
> Project: Hadoop YARN
> Issue Type: Improvement
> Affects Versions: 2.8.0
> Reporter: Tao Jie
> Assignee: Tao Jie
> Fix For: 2.8.0
>
> Attachments: YARN-5697.001.patch, YARN-5697.002.patch,
> YARN-5697.003.patch
>
>
> As discussed in YARN-4855, it is better to use CliParser rather than args to
> parse command line options in RMAdminCli.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
