On 04.06.25 19:53, ichthyo wrote:
(3) the new field InterChange::partsChange is needlessly public. Please make it private, to prevent any "convenient" grab at that field from the outside. This helps to reduce complexity.
And additionally, this field was intended to be static in the class InterChange, so that it is shared over all InterChange instances for all SynthEngine instances, correct? then we need the static modifier in InterChange.h at the place where the member field is declared (and not in the constructor, see next point) _______________________________________________ Yoshimi-devel mailing list Yoshimi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/yoshimi-devel
