On 07.06.25 00:12, Will Godfrey wrote:
I think this is pretty much complete for both the GUI and CLI, so see what you think :)
just skimmed through the changes ... looks fine. One minor itch though. We are now clearing this "instrument dirty" flag in two cases, where it seems we should not. CONFIG::control::saveCurrentConfig CONFIG::control::saveAllXMLdata The first one saves the intance config (yes, this can still be done explicitly from the CLI, and that is ok, esp. if you're running without UI). However, after having saved the config, your changed instrument settings are still there, and still unsaved. So the instrument / part should still be marked "dirty"... The second case changes the config setting about "minimal XML", i.e. if the settings of currently disabled components should be persisted. Here the same argument applies: changing this config setting does in no way alter the "dirty-ness" of any instrument / part. -- Hermann _______________________________________________ Yoshimi-devel mailing list Yoshimi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/yoshimi-devel