On 04.06.25 10:45, Will Godfrey wrote:
These would be the obvious place for monitoring changes, otherwise it becomes a line-by-line examination :(
On 04.06.25 20:41, Ichthyostega via Yoshimi-devel wrote:
So that should be doable with some hours of focussed attention.
...after my night round outside, it occurred to me that we both overestimated this problem. In fact it's not a big deal, because the CLI must only set off the warning; it is not necessary to capture the *changes*, because CmdInterpreter does that already. So it is a hand full of save / reset actions, and all of these are already identified, you just need to go through your changeset and look for which commands you clear the bitset.... case MAIN::control::loadInstrumentFromBank: case MAIN::control::loadInstrumentByName: case MAIN::control::saveNamedInstrument: case MAIN::control::loadNamedPatchset: case MAIN::control::saveNamedPatchset: case MAIN::control::loadNamedState: case MAIN::control::saveNamedState: case MAIN::control::defaultPart: case MAIN::control::defaultInstrument: case MAIN::control::masterReset: case MAIN::control::masterResetAndMlearn: case BANK::control::saveInstrument: these and only these reset the flag, and thus only for these there needs to be a warning. ...that means it is not necessary to go through all of the huge CmdInterpreter line by line... -- Hermann _______________________________________________ Yoshimi-devel mailing list Yoshimi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/yoshimi-devel
